[webkit-reviews] review granted: [Bug 127926] Add session support to WebPlatformStrategies : [Attachment 222789] fix test failure

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted  review:
Bug 127926: Add session support to WebPlatformStrategies
https://bugs.webkit.org/show_bug.cgi?id=127926

Attachment 222789: fix test failure
https://bugs.webkit.org/attachment.cgi?id=222789&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222789&action=review


r=me

> Source/WebKit2/Shared/SessionTracker.cpp:99
> +    if (staticSessionMap().contains(sessionID)) {
> +	   storageSessionToID().remove(session(sessionID));
> +	   staticSessionMap().remove(sessionID);

It's not great that we look up sessionID in staticSessionMap three times here.
It can be easily avoided by using find().

But this is not hot code at all.