[webkit-reviews] review granted: [Bug 127849] WebKit Bot Watcher's Dashboard: Access restricted queue should only prompt for HTTP credentials once per page load : [Attachment 222848] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 127849: WebKit Bot Watcher's Dashboard: Access restricted queue should only
prompt for HTTP credentials once per page load
https://bugs.webkit.org/show_bug.cgi?id=127849

Attachment 222848: Patch
https://bugs.webkit.org/attachment.cgi?id=222848&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222848&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/B
uildbot.js:109
> +	   // FIXME: We may want to assert that the authentication status
didn't change. When such an assertion fails
> +	   // it indirectly indicates that we made an synchronous HTTP request,
which we should avoid to ensure app
> +	   // responsiveness.

Sounds easier to just add the assert, and not a FIXME :)

We definitely shouldn't be making sync requests.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/B
uildbotQueue.js:166
> +		   // FIXME: Safari/WebKit should coallesce authentication
requests with the same origin and authentication realm.
> +		   // See <https://bugs.webkit.org/show_bug.cgi?id=128006>.

I usually use this format:

// FIXME (128006): Safari/WebKit should coallesce authentication requests with
the same origin and authentication realm.

It would be helpful to add a comment about what the observable effect of this
issue is in this particular case.