[webkit-reviews] review granted: [Bug 128018] Expose creation and modification times for LocalStorage : [Attachment 222854] with new file added

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 128018: Expose creation and modification times for LocalStorage
https://bugs.webkit.org/show_bug.cgi?id=128018

Attachment 222854: with new file added
https://bugs.webkit.org/attachment.cgi?id=222854&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222854&action=review


> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:429
> +void StorageManager::getStoragesByOrigin(FunctionDispatcher*
callbackDispatcher, void* context, void (*callback)(const
Vector<LocalStorageDetails>& storageDetails, void* context))

I don't think "storages" is a word. How about "storageDetails" or
"storageInformation"

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:644
> +void StorageManager::getStoragesByOriginInternal(FunctionDispatcher*
dispatcher, void* context, void (*callbackFunction)(const
Vector<LocalStorageDetails>& storageDetails, void* context))

Same comment here.