[webkit-reviews] review canceled: [Bug 127849] WebKit Bot Watcher's Dashboard: Access restricted queue should only prompt for HTTP credentials once per page load : [Attachment 222721] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has canceled Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 127849: WebKit Bot Watcher's Dashboard: Access restricted queue should only
prompt for HTTP credentials once per page load
https://bugs.webkit.org/show_bug.cgi?id=127849

Attachment 222721: Patch
https://bugs.webkit.org/attachment.cgi?id=222721&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Updated patch based on Alexey Proskuryakov's remarks.

It seems sufficient to have the browser prompt exactly once for each
access-restricted queue on page load and expose a way to trigger an
authentication dialog from the dashboard. This allows a person who doesn't have
permission to view the status of the queue to view the dashboard without the
annoyance of being prompted for credentials each time the queue update timer
fires (every 45 seconds as of the time of writing).

For now, I am removing the logic to work around bug #128006 as the effects of
this bug can be seen as an annoyance. That is, the effects don't significantly
impact the functionality of the dashboard. Ideally we should fix bug #128006 so
that we we only present a single authentication dialog for all
access-restricted queues associated with the same Buildbot. We can consider
adding back the work around should it turn out that it's either non-trivial to
fix bug #128006 or its effects are seen as a significant annoyance.