[webkit-reviews] review granted: [Bug 127868] IDB: Index reading/writing : [Attachment 222800] Writing v2 - Fix style nit.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 31 07:50:26 PST 2014


Anders Carlsson <andersca at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 127868: IDB: Index reading/writing
https://bugs.webkit.org/show_bug.cgi?id=127868

Attachment 222800: Writing v2 - Fix style nit.
https://bugs.webkit.org/attachment.cgi?id=222800&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222800&action=review


>
Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQ
Lite.cpp:239
> +	       IDBIndexMetadata idxMetadata;

No need to abbreviate index here.

>
Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQ
Lite.cpp:256
> +	       auto objectStoreMetadata =
metadata->objectStores.find(objectStoreID);

I'd call this objectStoreMetadataIt to indicate that it's an iterator
(especially since you're using auto).


More information about the webkit-reviews mailing list