[webkit-reviews] review granted: [Bug 127802] [CSS Shapes] Serialize basic shape positions : [Attachment 222573] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 30 21:55:20 PST 2014


Dean Jackson <dino at apple.com> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 127802: [CSS Shapes] Serialize basic shape positions
https://bugs.webkit.org/show_bug.cgi?id=127802

Attachment 222573: Patch
https://bugs.webkit.org/attachment.cgi?id=222573&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222573&action=review


> Source/WebCore/ChangeLog:8
> +	    Serialize basic shape positions by trying to detect keywords and
trying to be as close as possible to the original input.

Nit: extra whitespace char in indentation.

> Source/WebCore/ChangeLog:11
> +	   * css/BasicShapeFunctions.cpp:
> +	   (WebCore::valueForCenterCoordinate):

Could you describe what you did here?


More information about the webkit-reviews mailing list