[webkit-reviews] review granted: [Bug 127969] Push DOM attributes into the prototype chain : [Attachment 222763] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 127969: Push DOM attributes into the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=127969

Attachment 222763: Patch
https://bugs.webkit.org/attachment.cgi?id=222763&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222763&action=review


r=me

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:595
> +    my $hasNumericIndexedGetter = $indexedGetterFunction ?
$codeGenerator->IsNumericType($indexedGetterFunction->signature->type) : 0;

This variable seems to be unused. Is that a mistake?

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:621
> +    return 1;

This needs a comment to explain that it's temporary.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1266
> +

Stray newline.