[webkit-reviews] review denied: [Bug 115643] Document should be constructable : [Attachment 222642] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied László Langó
<llango.u-szeged at partner.samsung.com>'s request for review:
Bug 115643: Document should be constructable
https://bugs.webkit.org/show_bug.cgi?id=115643

Attachment 222642: Patch
https://bugs.webkit.org/attachment.cgi?id=222642&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222642&action=review


> Source/WebCore/dom/Document.h:262
> +	   return adoptRef(new Document(0, context.url()));

Please use nullptr instead of 0 here.

I don’t see why context.url() would be correct for this document. I think we
need to make a document without a URL here.

DOMImplementation.createDocument also sets the security origin on the document
it creates. I suspect we need to do the same here.

I think we need some test coverage that goes beyond “this is a document” and
checks these other properties of the document we create.