[webkit-reviews] review granted: [Bug 127922] [jhbuild] Disable escape sequences in EWS output : [Attachment 222715] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Csaba Osztrogonác
<ossy at webkit.org>'s request for review:
Bug 127922: [jhbuild] Disable escape sequences in EWS output
https://bugs.webkit.org/show_bug.cgi?id=127922

Attachment 222715: Patch
https://bugs.webkit.org/attachment.cgi?id=222715&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222715&action=review


> Tools/Scripts/webkitpy/common/system/environment.py:45
> +	   # or rxvt, which makes webkit-queues server set wrong MIME type.

Correction, it's not happening in webkit-queues server, it's in browser
(CFNetwork framework in Safari case, and I don't even know if other browsers
are affected).

Also, the escape sequences would be harmful even if they didn't affect MIME
type, because it's just garbage when viewed in browser.