[webkit-reviews] review granted: [Bug 127521] Sideways 'wobble' when scrolling with trackpad on Mavericks : [Attachment 222754] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 127521: Sideways 'wobble' when scrolling with trackpad on Mavericks
https://bugs.webkit.org/show_bug.cgi?id=127521

Attachment 222754: Patch
https://bugs.webkit.org/attachment.cgi?id=222754&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222754&action=review


> Source/WebCore/page/WheelEventDeltaTracker.h:57
> +    Deque<FloatSize> m_recentWheelEventDeltas;

This should probably have some inline capacity, matching recentEventCount.

> Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp:115
> +	   // This is a little crazy because it is working around
<rdar://problem/14758615>, which is a bug in a
> +	   // lower-level component. While that bug is still unresolved, this
will help to reduce some of the noise
> +	   // we are seeing with lots of small horizontal deltas when a user is
scrolling in primarily vertical
> +	   // direction and vice versa.

I think just // Work around <rdar://problem/14758615>
would be sufficient.