[webkit-reviews] review granted: [Bug 127937] WebGLLoadPolicy should be queried for the top document : [Attachment 222723] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 30 14:58:22 PST 2014


Tim Horton <thorton at apple.com> has granted Roger Fong <roger_fong at apple.com>'s
request for review:
Bug 127937: WebGLLoadPolicy should be queried for the top document
https://bugs.webkit.org/show_bug.cgi?id=127937

Attachment 222723: patch
https://bugs.webkit.org/attachment.cgi?id=222723&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222723&action=review


> Source/WebCore/html/HTMLCanvasElement.cpp:-229
> -		   Page* page = document().page();

I asked if this was right because it means that trusting the main document's
domain would let subdocuments from origins the user doesn't trust run, and he
noted that plugins do the same thing, so I think this is fine (but maybe we
should revisit this?).


More information about the webkit-reviews mailing list