[webkit-reviews] review granted: [Bug 127866] IDB: ObjectStore cursor advance() support : [Attachment 222725] Patch v2 - build fix

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 127866: IDB: ObjectStore cursor advance() support
https://bugs.webkit.org/show_bug.cgi?id=127866

Attachment 222725: Patch v2 - build fix
https://bugs.webkit.org/attachment.cgi?id=222725&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222725&action=review


> Source/WebKit2/DatabaseProcess/IndexedDB/IDBIdentifier.h:84
> +    DatabaseProcessIDBConnection& connection() const { return *m_connection;
}

You should ASSERT(m_connection) here.

> Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:43
> +    std::unique_ptr<SQLiteIDBCursor> cursor =
std::unique_ptr<SQLiteIDBCursor>(new SQLiteIDBCursor(transaction,
cursorIdentifier, objectStoreID, indexID, cursorDirection, cursorType,
taskType, keyRange));

This should use auto and make_unique<>

> Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:41
>
+SQLiteIDBTransaction::SQLiteIDBTransaction(UniqueIDBDatabaseBackingStoreSQLite
* backingStore, const IDBIdentifier& transactionIdentifier,
IndexedDB::TransactionMode mode)

Could backingStore be a reference?