[webkit-reviews] review granted: [Bug 127939] Begin fleshing out the navigation delegate : [Attachment 222718] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 30 13:16:57 PST 2014
mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 127939: Begin fleshing out the navigation delegate
https://bugs.webkit.org/show_bug.cgi?id=127939
Attachment 222718: Patch
https://bugs.webkit.org/attachment.cgi?id=222718&action=review
------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222718&action=review
> Source/WebKit2/UIProcess/Cocoa/NavigationState.h:73
> + WKWebView* m_webView;
Star on the wrong side.
> Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:110
> + case WKNavigationPolicyDecisionAllow:
> + listener->use();
> + break;
> +
> + case WKNavigationPolicyDecisionCancel:
> + listener->ignore();
> + break;
> +
> + case WKNavigationPolicyDecisionDownload:
> + listener->download();
This is over-indented.
More information about the webkit-reviews
mailing list