[webkit-reviews] review denied: [Bug 127926] Add session support to WebPlatformStrategies : [Attachment 222698] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Martin Hock <mhock at apple.com>'s
request for review:
Bug 127926: Add session support to WebPlatformStrategies
https://bugs.webkit.org/show_bug.cgi?id=127926

Attachment 222698: patch
https://bugs.webkit.org/attachment.cgi?id=222698&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222698&action=review


> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:48
>  void WebFrameNetworkingContext::ensurePrivateBrowsingSession(uint64_t
sessionID)
>  {
> -    if (SessionTracker::session(sessionID))
> +    if (sessionID == SessionTracker::defaultSessionID ||
SessionTracker::session(sessionID))
>	   return;

I don't think that this is quite right. The function name means that it can be
only invoked with private browsing sessions, so having a check for whether the
session is private inside it is too late.