[webkit-reviews] review granted: [Bug 127925] Make TestWebKitAPI build and run for iOS : [Attachment 222695] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 30 11:28:57 PST 2014


Andy Estes <aestes at apple.com> has granted David Farler <dfarler at apple.com>'s
request for review:
Bug 127925: Make TestWebKitAPI build and run for iOS
https://bugs.webkit.org/show_bug.cgi?id=127925

Attachment 222695: Patch
https://bugs.webkit.org/attachment.cgi?id=222695&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222695&action=review


> Tools/TestWebKitAPI/Configurations/Base.xcconfig:67
> +EXCLUDED_SOURCE_FILE_NAMES_iphoneos = *Mac.h *Mac.cpp *Mac.mm
*InjectedBundle* *PlatformUtilities* Tests/WebKit2/* Tests/WebKit2ObjC/*
*_Bundle* JavaScriptTest.* */mac/* CustomProtocolsSyncXHRTest.mm;

Shouldn't CustomProtocolsSyncXHRTest.mm already be excluded by virtue of being
in Tests/WebKit2ObjC/?


More information about the webkit-reviews mailing list