[webkit-reviews] review denied: [Bug 127887] Make it possible to implement JS builtins in JS : [Attachment 222686] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 127887: Make it possible to implement JS builtins in JS
https://bugs.webkit.org/show_bug.cgi?id=127887

Attachment 222686: Patch
https://bugs.webkit.org/attachment.cgi?id=222686&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222686&action=review


> Source/JavaScriptCore/DerivedSources.make:86
> +JSCBuiltins: $(JavaScriptCore)/JSCBuiltins.h
$(JavaScriptCore)/JSCBuiltins.cpp

I think this needs to be the build target; It thinks it should be finding
"Source/JavaScriptCore/JSCBuiltins.{h,cpp}", but they are actually build in
"${WebKit_Output}/${Configuration}/DerivedSources/JavaScriptCore/" (or
something like that).