[webkit-reviews] review granted: [Bug 127891] WebKit2 View Gestures (Swipe): Provide a way for clients to provide views to swipe : [Attachment 222647] ever so slightly more crazy

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 127891: WebKit2 View Gestures (Swipe): Provide a way for clients to provide
views to swipe
https://bugs.webkit.org/show_bug.cgi?id=127891

Attachment 222647: ever so slightly more crazy
https://bugs.webkit.org/attachment.cgi?id=222647&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222647&action=review


> Source/WebKit2/UIProcess/mac/ViewGestureController.h:61
> +    void setCustomSwipeViews(Vector<RetainPtr<NSView>> views) {
m_customSwipeViews = views; }

std::move(views).

> Source/WebKit2/UIProcess/mac/ViewGestureController.h:62
> +    Vector<RetainPtr<NSView>> customSwipeViews() const { return
m_customSwipeViews; }

You don't want to return this by reference?