[webkit-reviews] review granted: [Bug 127877] Allow the OpenGL Profiler to get through the sandbox : [Attachment 222682] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 127877: Allow the OpenGL Profiler to get through the sandbox
https://bugs.webkit.org/show_bug.cgi?id=127877

Attachment 222682: Patch
https://bugs.webkit.org/attachment.cgi?id=222682&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222682&action=review


r=me

Please upload a fixed patch though to let EWS chew on it and see what happens
on Mountain Lion.

>
Source/WebKit2/Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.s
b:233
> +    (allow mach-register (global-name-regex
#”^_oglprof_attach_<[0-9]+>$")))

Looks like you've got a smart quote here, which will break everything.

> Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in:88
> +    (allow mach-register (global-name-regex
#”^_oglprof_attach_<[0-9]+>$")))

Ditto.