[webkit-reviews] review granted: [Bug 21242] [CURL] Should handle redirects in WebCore : [Attachment 222089] First draft
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 30 10:07:46 PST 2014
Brent Fulgham <bfulgham at webkit.org> has granted Szabolcs David
<davidsz at inf.u-szeged.hu>'s request for review:
Bug 21242: [CURL] Should handle redirects in WebCore
https://bugs.webkit.org/show_bug.cgi?id=21242
Attachment 222089: First draft
https://bugs.webkit.org/attachment.cgi?id=222089&action=review
------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222089&action=review
This seems fine to me, but someone using the Curl backend more frequently
should confirm it doesn't cause any problems.
> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:404
> + String location = d->m_response.httpHeaderField("location");
This could probably be a const String&
More information about the webkit-reviews
mailing list