[webkit-reviews] review denied: [Bug 127877] Allow the OpenGL Profiler to get through the sandbox : [Attachment 222611] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Dean Jackson <dino at apple.com>'s
request for review:
Bug 127877: Allow the OpenGL Profiler to get through the sandbox
https://bugs.webkit.org/show_bug.cgi?id=127877

Attachment 222611: Patch
https://bugs.webkit.org/attachment.cgi?id=222611&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222611&action=review


EWS is right - the current patch breaks launching WebProcess on Mountain Lion.
Here is what I see in the uploaded results archive:

WebProcess: Couldn't initialize sandbox profile
[/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit2.framework/Resources/com.a
pple.WebProcess.sb], error 'line 88: unbound variable: mach-register '

We should make this conditional on low level OS support with (if (defined?
'mach-register) ...).

> Source/WebKit2/ChangeLog:5
> +	   <rdar://problem/14817250>

This patch also fixes <rdar://problem/14271180>, please add it to ChangeLog.

> Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in:88
> +    (global-name-regex #"_oglprof_attach_.*"))

This rule is not quite what was suggested to us. Let's chat offline about why
it is so.