[webkit-reviews] review granted: [Bug 127885] Web Inspector: Play Breakpoint Sound in Frontend : [Attachment 222622] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 127885: Web Inspector: Play Breakpoint Sound in Frontend
https://bugs.webkit.org/show_bug.cgi?id=127885

Attachment 222622: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=222622&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222622&action=review


> Source/JavaScriptCore/inspector/ScriptDebugListener.h:76
> +    virtual void breakpointActionSound(int breakpointActionIdentifier) = 0;

Can we use unsigned? I hate int for things that don't need to be negative.
Positive positive positive!

> Source/JavaScriptCore/inspector/protocol/Debugger.json:304
> +	       "name": "breakpointSound",

playBreakpointSound? Any verb would help here.