[webkit-reviews] review denied: [Bug 127588] [CSS Shapes] Image valued shape can fail : [Attachment 222531] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Hans Muller <giles_joplin at yahoo.com>'s
request for review:
Bug 127588: [CSS Shapes] Image valued shape can fail
https://bugs.webkit.org/show_bug.cgi?id=127588

Attachment 222531: Patch
https://bugs.webkit.org/attachment.cgi?id=222531&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222531&action=review


r-

Seems muddled with regards to vertical writing.

> Source/WebCore/rendering/shapes/ShapeInfo.cpp:75
> +static LayoutRect getShapeImageMarginRect(const RenderBox& renderBox, const
LayoutSize& shapeSize)
> +{
> +    LayoutPoint marginBoxOrigin(-renderBox.marginLogicalLeft() -
renderBox.borderAndPaddingLogicalLeft(), -renderBox.marginTop() -
renderBox.borderTop() - renderBox.paddingTop());
> +    LayoutSize marginBoxSizeDelta(renderBox.marginLogicalWidth() +
renderBox.borderAndPaddingLogicalWidth(), renderBox.marginLogicalHeight() +
renderBox.borderAndPaddingLogicalHeight());
> +    return LayoutRect(marginBoxOrigin, shapeSize + marginBoxSizeDelta);
> +}

This looks wrong with vertical writing. You're mixing physical and logical
margins.