[webkit-reviews] review granted: [Bug 127784] WebKit Bot Watcher's Dashboard: Add support for using HTTP authentication with Buildbot : [Attachment 222588] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 127784: WebKit Bot Watcher's Dashboard: Add support for using HTTP
authentication with Buildbot
https://bugs.webkit.org/show_bug.cgi?id=127784

Attachment 222588: Patch
https://bugs.webkit.org/attachment.cgi?id=222588&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222588&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/B
uildbotQueue.js:65
> +    get needsAuthentication()
> +    {
> +	   return this.buildbot.needsAuthentication;
> +    },

I'd just put this check inline - we don't need to create a concept of a queue
that needs authentication, it's the server that does.