[webkit-reviews] review granted: [Bug 127739] Add a method for schemes to be registered as supporting cache partitioning : [Attachment 222509] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jeffrey Pfau <jpfau at apple.com>'s
request for review:
Bug 127739: Add a method for schemes to be registered as supporting cache
partitioning
https://bugs.webkit.org/show_bug.cgi?id=127739

Attachment 222509: Patch
https://bugs.webkit.org/attachment.cgi?id=222509&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222509&action=review


> Source/WebCore/page/SecurityOrigin.h:210
> +    // This method checks that the scheme for this origin is an HTTP-family
> +    // scheme, e.g. HTTP and HTTPS.
> +    bool isHTTPFamily() const { return m_protocol == "http" || m_protocol ==
"https"; }

The mix in terminology here between protocol and scheme is unnecessarily
confusing.

Why is this function public instead of private?