[webkit-reviews] review granted: [Bug 127809] REGRESSION (r162947): css3/flexbox/multiline-justify-content.html and css3/flexbox/position-absolute-child.html are timing out : [Attachment 222572] another

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 127809: REGRESSION (r162947): css3/flexbox/multiline-justify-content.html
and css3/flexbox/position-absolute-child.html are timing out
https://bugs.webkit.org/show_bug.cgi?id=127809

Attachment 222572: another
https://bugs.webkit.org/attachment.cgi?id=222572&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222572&action=review


I don't like the "gridSize()" concept, but I can't really think of something
better...

> Source/WebCore/rendering/RenderView.cpp:640
> +    static const unsigned maximumRepaintRegionGridSize = 16 * 16;
> +    if (m_accumulatedRepaintRegion->gridSize() >
maximumRepaintRegionGridSize)
> +	   m_accumulatedRepaintRegion =
std::make_unique<Region>(m_accumulatedRepaintRegion->bounds());

I think this could use a comment.