[webkit-reviews] review granted: [Bug 127816] Web Inspector: [REGRESSION(r162931)] Tab navigation broken in DataGrid : [Attachment 222528] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Diego Pino <dpino at igalia.com>'s
request for review:
Bug 127816: Web Inspector: [REGRESSION(r162931)] Tab navigation broken in
DataGrid
https://bugs.webkit.org/show_bug.cgi?id=127816

Attachment 222528: Patch
https://bugs.webkit.org/attachment.cgi?id=222528&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222528&action=review


> Source/WebInspectorUI/UserInterface/DataGrid.js:361
>		       return
this._startEditingColumnOfDataGridNode(currentEditingNode, 1);

There are a few 1s and 0s in this function that should also be strings for
clarity. Right now they are being converted later into string.

> Source/WebInspectorUI/UserInterface/DataGrid.js:375
>		       return
this._startEditingColumnOfDataGridNode(currentEditingNode, 0);

Another 0, but there are more.