[webkit-reviews] review denied: [Bug 127135] GraphicsContext::drawLineForText in PLATFORM(IOS) saves and restores graphics context state unnecessarily : [Attachment 222475] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 127135: GraphicsContext::drawLineForText in PLATFORM(IOS) saves and
restores graphics context state unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=127135

Attachment 222475: Patch
https://bugs.webkit.org/attachment.cgi?id=222475&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222475&action=review


> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1461
> +    if (m_state.shouldUseContextColors)
> +#endif

I hate #ifdeffed control flow.

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1474
> +	   if (fillColorIsNotEqualToStrokeColor)
> +	       setCGFillColor(platformContext(), fillColor(),
fillColorSpace());

This indentation looks wrong.