[webkit-reviews] review granted: [Bug 127386] Improve latching behavior for wheel events : [Attachment 222493] Patch (Revised to Build on WIndows/GTK/EFL)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 28 14:41:42 PST 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 127386: Improve latching behavior for wheel events
https://bugs.webkit.org/show_bug.cgi?id=127386

Attachment 222493: Patch (Revised to Build on WIndows/GTK/EFL)
https://bugs.webkit.org/attachment.cgi?id=222493&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222493&action=review


> Source/WebCore/platform/ScrollAnimator.cpp:86
> +    if (e.phase() == PlatformWheelEventPhaseMayBegin)
> +	   return true;

Please add a comment describing why this is necessary and note where the call
is coming from.


More information about the webkit-reviews mailing list