[webkit-reviews] review canceled: [Bug 127785] [CSS Shapes] Adjust inset sizing syntax to the latest spec : [Attachment 222469] Patch

[bugzilla-daemon at webkit.org]

Zoltan Horvath <zoltan at webkit.org> has canceled Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 127785: [CSS Shapes] Adjust inset sizing syntax to the latest spec
https://bugs.webkit.org/show_bug.cgi?id=127785

Attachment 222469: Patch
https://bugs.webkit.org/attachment.cgi?id=222469&action=review

------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>
(In reply to comment #2)
> (From update of attachment 222469 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=222469&action=review
> 
> > Source/WebCore/css/CSSParser.cpp:5409
> > +	 if (widthArguments.size() == 1) {
> 
> I think a switch would be more readable here.

I modified to use switch.

> > Source/WebCore/css/CSSParser.cpp:5422
> > +	     shape->setBottom(widthArguments[2]);
> 
> You need to set Left here, and double check your tests, if this passed, you
missed a test.

That behavior was the expected in my mind. :( I added the corrected case and I
modified the affected test.