[webkit-reviews] review granted: [Bug 112024] Sticky positioning is broken for table rows : [Attachment 222471] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Viatcheslav Ostapenko
<ostap73 at gmail.com>'s request for review:
Bug 112024: Sticky positioning is broken for table rows
https://bugs.webkit.org/show_bug.cgi?id=112024

Attachment 222471: Patch
https://bugs.webkit.org/attachment.cgi?id=222471&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222471&action=review


>>> Source/WebCore/rendering/RenderBox.cpp:3093
>>> +	     const RenderBlock* cb = containingBlock->isRenderBlock() ?
toRenderBlock(containingBlock) : containingBlock->containingBlock();
>> 
>> It's pretty confusing that a parameter called "containingBlock" is not
actually the containingBlock. Should we make the parameter a RenderBlock* and
fix the callers?
> 
> It appears to be pretty big change, because there are other methods (like
containingBlockLogicalWidthForPositioned) that have the same problem and they
call containingBlockLogicalHeightForPositioned .
> Can it be done in another patch?

OK. Also in some rare cases containingBlock() can return nil; not sure if we
need to handle that here.