[webkit-reviews] review granted: [Bug 127390] WebKit2 View Gestures (Swipe): Snapshots should be purgeable : [Attachment 222467] patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 127390: WebKit2 View Gestures (Swipe): Snapshots should be purgeable
https://bugs.webkit.org/show_bug.cgi?id=127390

Attachment 222467: patch
https://bugs.webkit.org/attachment.cgi?id=222467&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222467&action=review


> Source/WebKit2/UIProcess/mac/ViewGestureController.mm:51
> +static const uint32_t WebKitIOSurfacePurgeableNonVolatile = 0;
> +static const uint32_t WebKitIOSurfacePurgeableVolatile = 1;
> +static const uint32_t WebKitIOSurfacePurgeableEmpty = 2;

I think you should use a real enum here with real IOSurface names.

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:46
> +static const uint32_t WebKitIOSurfacePurgeableVolatile = 1;

Real enum.