[webkit-reviews] review granted: [Bug 127648] -[JSContext evaluteScript:] calls JSEvaluteScript with startingLineNumber 0, later interpreted as a oneBasedInt : [Attachment 222384] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 27 21:49:20 PST 2014
Geoffrey Garen <ggaren at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 127648: -[JSContext evaluteScript:] calls JSEvaluteScript with
startingLineNumber 0, later interpreted as a oneBasedInt
https://bugs.webkit.org/show_bug.cgi?id=127648
Attachment 222384: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=222384&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me
I'd remove "is interpreted", to be more direct, and hyphenate "one-based",
since it's an adjective.
More information about the webkit-reviews
mailing list