[webkit-reviews] review granted: [Bug 127756] Crash in RemoteLayerBackingStore::encode when m_frontBuffer is nullptr. : [Attachment 222399] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 127756: Crash in RemoteLayerBackingStore::encode when m_frontBuffer is
nullptr.
https://bugs.webkit.org/show_bug.cgi?id=127756

Attachment 222399: Patch
https://bugs.webkit.org/attachment.cgi?id=222399&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222399&action=review


At the least, this seems likely to be an incomplete fix, because whatever is
causing this seems like it would also cause a failure in the
m_acceleratesDrawing branch.

Do you know why it is that we are encoding a backing store that has never been
painted? Is this a custom layer or something?

> Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm:97
> +    {

These go on the previous line.