[webkit-reviews] review granted: [Bug 127671] WebCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed : [Attachment 222303] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 127671: WebCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH
annotation where needed
https://bugs.webkit.org/show_bug.cgi?id=127671

Attachment 222303: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=222303&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222303&action=review


> Source/WebCore/css/SVGCSSParser.cpp:274
> +	   break;

Nice catch!

> Source/WebCore/css/StyleResolver.cpp:2230
> +	       return;
>	   }
> +	   

Ditto!

> Source/WebCore/rendering/AutoTableLayout.cpp:-523
> -	       // fall through

Huh, out-dated comment. That's classic.