[webkit-reviews] review granted: [Bug 127702] [iOS] preload=none prevents play() : [Attachment 222358] Proposed patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 127702: [iOS] preload=none prevents play()
https://bugs.webkit.org/show_bug.cgi?id=127702

Attachment 222358: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=222358&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222358&action=review


r=me, with nit:

> Source/WebCore/html/HTMLMediaElement.cpp:4257
>  #if PLATFORM(IOS)
> -    if (shouldBePlaying && !m_requestingPlay &&
!m_player->readyForPlayback())
> -	   shouldBePlaying = false;
> -    else if (!shouldBePlaying && m_requestingPlay &&
m_player->readyForPlayback())
> -	   shouldBePlaying = true;
> +    if (shouldUseVideoPluginProxy()) {
> +	   if (shouldBePlaying && !m_requestingPlay &&
!m_player->readyForPlayback())
> +	       shouldBePlaying = false;
> +	   else if (!shouldBePlaying && m_requestingPlay &&
m_player->readyForPlayback())
> +	       shouldBePlaying = true;
> +    }
>  #endif

Could this #if PLATFORM(IOS) be replaced by #if ENABLE(PLUGIN_PROXY_FOR_VIDEO)?