[webkit-reviews] review granted: [Bug 127701] [iOS] Use callOnMainThread() not dispatch_async() in MediaPlayerPrivateAVFoundationObjC : [Attachment 222352] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 27 14:04:26 PST 2014


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 127701: [iOS] Use callOnMainThread() not dispatch_async() in
MediaPlayerPrivateAVFoundationObjC
https://bugs.webkit.org/show_bug.cgi?id=127701

Attachment 222352: Patch
https://bugs.webkit.org/attachment.cgi?id=222352&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222352&action=review


>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:2124
> +	   if (strongSelf->m_callback)
> +	      
strongSelf->m_callback->didCancelLoadingRequest(strongRequest.get());

Why do you use "strongSelf->m_callback" here, but just "m_callback" everywhere
else?


More information about the webkit-reviews mailing list