[webkit-reviews] review granted: [Bug 127660] JSC: Pack unlinked instructions harder. : [Attachment 222289] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 127660: JSC: Pack unlinked instructions harder.
https://bugs.webkit.org/show_bug.cgi?id=127660

Attachment 222289: Patch
https://bugs.webkit.org/attachment.cgi?id=222289&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222289&action=review


R=me.  I like this a lot.  Please consider removing the NDEBUG guards, since in
JSC we tend to make debug support code available in release builds to enable
easy release debugging.

> Source/JavaScriptCore/bytecode/UnlinkedInstructionStream.cpp:180
> +#ifndef NDEBUG

I would remove the #ifndef NDEBUG guard for this.  It's very common to do
"debugging" on JSC in release mode, and we don't generally have NDEBUG guards
on debug support.