[webkit-reviews] review granted: [Bug 127613] Web Inspector: In a DataGrid, store value of columnIdentifier to DOM node representing a cell : [Attachment 222234] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Diego Pino
<dpino at igalia.com>'s request for review:
Bug 127613: Web Inspector: In a DataGrid, store value of columnIdentifier to
DOM node representing a cell
https://bugs.webkit.org/show_bug.cgi?id=127613

Attachment 222234: Patch
https://bugs.webkit.org/attachment.cgi?id=222234&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222234&action=review


r=me

> Source/WebInspectorUI/UserInterface/DataGrid.js:156
> +	   td.columnIdentifier = columnIdentifier;

As Tim suggested, we should use "__columnIdentifier".

We typically use "__foo" syntax for property names when one class is storing
properties on another object, and that other object has no knowledge of the
existence of that property. Though ".columnIdentifier" works, it is not
immediately clear if you're debugging this element that the property is
something we injected onto the element. And having it show up as obvious in the
debugger can sometimes be helpful! Also, if in the further that object wanted
to add a "columnIdentifier" property then the double underscore would avoid a
naming conflict.