[webkit-reviews] review granted: [Bug 127632] Remove some iOS #ifdefs by adding SQLiteDatabaseTracker to all the builds : [Attachment 222236] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 127632: Remove some iOS #ifdefs by adding SQLiteDatabaseTracker to all the
builds
https://bugs.webkit.org/show_bug.cgi?id=127632

Attachment 222236: Patch
https://bugs.webkit.org/attachment.cgi?id=222236&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222236&action=review


> Source/WebCore/platform/sql/SQLiteDatabaseTracker.cpp:37
> +static SQLiteDatabaseTrackerClient* s_staticSQLiteDatabaseTrackerClient = 0;


nullptr (or omit)

> Source/WebCore/platform/sql/SQLiteDatabaseTracker.cpp:40
> +static Mutex& transactionInProgressMutex()

Can we use C++ standard library locking instead of WTF locking?

> Source/WebCore/platform/sql/SQLiteDatabaseTracker.h:43
> +#if !ASSERT_DISABLED
> +bool hasTransactionInProgress();
> +#endif // !ASSERT_DISABLED

That endif comment. Really?