[webkit-reviews] review granted: [Bug 127617] [CSS Shapes] inset() function with multiple spaces on element style : [Attachment 222212] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 127617: [CSS Shapes] inset() function with multiple spaces on element style
https://bugs.webkit.org/show_bug.cgi?id=127617

Attachment 222212: Patch
https://bugs.webkit.org/attachment.cgi?id=222212&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222212&action=review


r=me with comments.

> Source/WebCore/css/CSSBasicShapes.cpp:428
> +    if (!right.isNull()) {
> +	   result.appendLiteral(separator);
> +	   result.append(right);
> +	   if (!bottom.isNull()) {
> +	       result.appendLiteral(separator);
> +	       result.append(bottom);
> +	       if (!left.isNull()) {
> +		   result.appendLiteral(separator);
> +		   result.append(left);
> +	       }
> +	   }
> +    }

I don't think that it needs to be nested... At this point we should be able to
rely on sane data, shouldn't we? Of course we would have some extra checks
though. I leaf it up to you.

> Source/WebCore/css/CSSBasicShapes.cpp:444
> +	   result.append("/");

s/"/'/g