[webkit-reviews] review granted: [Bug 125659] Subpixel layout: RenderInline is not centered when child RenderTextControl's innerTextRenderer needs bias centering. : [Attachment 222216] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Zalan Bujtas <zalan at apple.com>'s
request for review:
Bug 125659: Subpixel layout: RenderInline is not centered when child
RenderTextControl's innerTextRenderer needs bias centering.
https://bugs.webkit.org/show_bug.cgi?id=125659

Attachment 222216: Patch
https://bugs.webkit.org/attachment.cgi?id=222216&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222216&action=review


r=me

> Source/WebCore/rendering/RenderTextControlSingleLine.h:46
> +    void centerRenderer(RenderBox& renderer) const;

Maybe we could call this centerInnerRenderer() to make it clear that it centers
it within itself.
Also we can omit the argument name here.