[webkit-reviews] review denied: [Bug 127616] Web Inspector: Value 'inherit' should be allowed for any CSS property, even if it is a non-inheritable property : [Attachment 222204] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Diego Pino <dpino at igalia.com>'s
request for review:
Bug 127616: Web Inspector: Value 'inherit' should be allowed for any CSS
property, even if it is a non-inheritable property
https://bugs.webkit.org/show_bug.cgi?id=127616

Attachment 222204: Patch
https://bugs.webkit.org/attachment.cgi?id=222204&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
We discussed this on IRC. I'm going to r-. Although this is technically
correct, our existing behavior is smart and would be more useful to users.

Currently we always autocomplete "initial", and we only autocomplete "inherit"
on inheritable properties (e.g. color, but not background-image).

That makes sense, because on a non-inheritable property, "inherit" would just
mean "initial", the default value.

And, like Tim suggested, we don't support "unset" yet. We don't want to show
properties in the frontend that a backend does not yet support. Currently if
you typed "color: unset" in Web Inspector, it would get a red strike through.
That would be weird if we showed it as an autocomplete suggestion =).