[webkit-reviews] review granted: [Bug 127615] Web Inspector: Position the completion suggestions popup below if there is room : [Attachment 222199] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Diego Pino
<dpino at igalia.com>'s request for review:
Bug 127615: Web Inspector: Position the completion suggestions popup below if
there is room
https://bugs.webkit.org/show_bug.cgi?id=127615

Attachment 222199: Patch
https://bugs.webkit.org/attachment.cgi?id=222199&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222199&action=review


Nice! r=me with some style nits.

> Source/WebInspectorUI/ChangeLog:6
> +	   Web Inspector: Position the completion suggestions popup below if
> +	   there is room enough.
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=127615

Style: `./Tools/Scripts/prepare-ChangeLog -b 127615` would not wrap the title
line and would put the bugzilla bug on the next line without an empty line
between.

> Source/WebInspectorUI/UserInterface/CompletionSuggestionsView.js:153
> +	   // Position the suggestions below the anchor. If there is no room,
position the suggestions above

Style: Comments in WebKit are full sentences. This second sentence should end
in a period.