[webkit-reviews] review granted: [Bug 127605] Web Inspector: Move InspectorRuntimeAgent into JavaScriptCore : [Attachment 222189] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 127605: Web Inspector: Move InspectorRuntimeAgent into JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=127605

Attachment 222189: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=222189&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222189&action=review


> Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.cpp:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

2013, 2014?

> Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.cpp:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

2014

> Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.h:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

2014

> Source/WebCore/inspector/PageRuntimeAgent.cpp:56
> +PageRuntimeAgent::PageRuntimeAgent(InjectedScriptManager*
injectedScriptManager, Page* page, InspectorPageAgent* pageAgent)

We might want to consider putting Inspector back in these subclass names. Page
or Web?

> Source/WebCore/inspector/PageRuntimeAgent.h:70
> +    virtual JSC::VM* globalVM() override;

final too?

> Source/WebCore/inspector/WorkerRuntimeAgent.h:59
> +    virtual JSC::VM* globalVM() override;

Ditto.