[webkit-reviews] review granted: [Bug 127582] ASSERT(!m_markedSpace.m_currentDelayedReleaseScope) reloading page in inspector : [Attachment 222160] the patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 24 15:22:19 PST 2014


Mark Hahnenberg <mhahnenberg at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 127582: ASSERT(!m_markedSpace.m_currentDelayedReleaseScope) reloading page
in inspector
https://bugs.webkit.org/show_bug.cgi?id=127582

Attachment 222160: the patch.
https://bugs.webkit.org/attachment.cgi?id=222160&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222160&action=review


r=me

> Source/JavaScriptCore/ChangeLog:19
> +	   while the JSGlobalObject is destructing, which in turn means that a
GC
> +	   is progress. It's not legal to iterate the heap while a GC is in

Not true. We were in the middle of sweeping, not collecting.


More information about the webkit-reviews mailing list