[webkit-reviews] review denied: [Bug 127589] GetTypedArrayOffset in FTL : [Attachment 222159] GetTypedArrayOffset in FTL implemented

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Matthew Mirman <mmirman at apple.com>'s
request for review:
Bug 127589: GetTypedArrayOffset in FTL
https://bugs.webkit.org/show_bug.cgi?id=127589

Attachment 222159: GetTypedArrayOffset in FTL implemented
https://bugs.webkit.org/attachment.cgi?id=222159&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222159&action=review


Almost there but fix style.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:1629
> +	   m_out.branch( m_out.notEqual( baseAddress ,
m_out.constIntPtr(WastefulTypedArray))
> +		       , simpleCase
> +		       , wastefulCase
> +		       );

Bad style:

- Shouldn't have a space between "branch(" and "m_out", and then again between
"notEqual(" and "baseAddress".	In general we don't do spaces between the open
paren and the stuff inside.

- Should put the commas on the previous line at those linebreaks.

- When you wrap a line, always indent 4 spaces and never more.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:1651
> +	   // output

You probably don't need this comment.