[webkit-reviews] review granted: [Bug 127448] Make WebKitTestRunner work with iOS : [Attachment 222142] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 24 13:28:07 PST 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 127448: Make WebKitTestRunner work with iOS
https://bugs.webkit.org/show_bug.cgi?id=127448

Attachment 222142: Patch
https://bugs.webkit.org/attachment.cgi?id=222142&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222142&action=review


> Tools/WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

These should all be 2014

> Tools/WebKitTestRunner/TestController.cpp:315
> +#if !PLATFORM(IOS)
>  #if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED > 1080

I think we do want this now.


More information about the webkit-reviews mailing list