[webkit-reviews] review denied: [Bug 127442] PutByIdDirect in FTL : [Attachment 221893] Adds PutByIdDirect capabilities to FTL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 24 12:38:49 PST 2014


Filip Pizlo <fpizlo at apple.com> has denied Matthew Mirman <mmirman at apple.com>'s
request for review:
Bug 127442: PutByIdDirect in FTL
https://bugs.webkit.org/show_bug.cgi?id=127442

Attachment 221893: Adds PutByIdDirect capabilities to FTL
https://bugs.webkit.org/attachment.cgi?id=221893&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221893&action=review


This looks good but please revert the whitespace changes.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:-30
> -

Revert!  We generally try to minimize whitespace changes, especially in
otherwise small patches.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:1518
> +

Revert!


More information about the webkit-reviews mailing list