[webkit-reviews] review granted: [Bug 127523] Generic JSObject::put should handle static properties in the classinfo hierarchy : [Attachment 222127] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 127523: Generic JSObject::put should handle static properties in the
classinfo hierarchy
https://bugs.webkit.org/show_bug.cgi?id=127523

Attachment 222127: Patch
https://bugs.webkit.org/attachment.cgi?id=222127&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222127&action=review


r=me

> Source/JavaScriptCore/ChangeLog:12
> +	   To make this not clobber performance, the ClassInfo HashTable
> +	   now includes a flag to indicate that it contains setters. This

You should specify the performance tests you ran: Dromaeo, and
run-jsc-benchmarks.