[webkit-reviews] review granted: [Bug 127532] Removing the need for Debugger* and m_shouldPause op_debug check : [Attachment 222118] patch for landing: all fixes have been applied.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted  review:
Bug 127532: Removing the need for Debugger* and m_shouldPause op_debug check
https://bugs.webkit.org/show_bug.cgi?id=127532

Attachment 222118: patch for landing: all fixes have been applied.
https://bugs.webkit.org/attachment.cgi?id=222118&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222118&action=review


r=me

> Source/JavaScriptCore/debugger/Debugger.cpp:245
>  void Debugger::unregisterCodeBlock(CodeBlock* codeBlock)
>  {
> -    codeBlock->clearAllBreakpoints();
> +    codeBlock->clearDebuggerRequests();

I think in a previous patch review I suggested removing this function and its
callers altogether.